Repository navigation
merge queue: checking #1663 on main (92830db) - #1664
Closed
mergify[bot] wants to merge 4 commits into
Closed
mergify[bot] wants to merge 4 commits into
mergify[bot] wants to merge 4 commits into
Conversation
Hall is a stub that renders nothing; fixtures, dictionary keys and the registry entry are in place so the tests compile and fail. Test-First: src/design/hall/Hall.test.tsx::every hall view shows the Beispieldaten label Test-First: src/design/hall/Hall.test.tsx::an empty hall says so in words and shows no figure in the work pose Test-First: src/design/hall/Hall.test.tsx::an unread hall says it is not read yet Test-First: src/design/hall/Hall.test.tsx::a missing state shows the unknown pose Test-First: src/design/hall/Hall.test.tsx::three work pieces each carry a text name Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hall draws the floor layout, the four stations with their role figures, the gate, three synthetic work pieces (new piece-crate-0 tile, atlas regenerated) and one evidence stamp. Every view says "Beispieldaten"; empty and unread halls say so in words. Figures get their pose only through poseFor: a role without a piece is ready, a piece without a state stays unknown (R1646-K1). Sprite geometry is plain numbers in CSS custom properties; hall.css scales them with the whole-device-pixel factor from usePixelScale and loads only the active theme's atlas. Regression-For: 2f27151 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No-Test: plan text only Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch shining-cantadou-qdwycg of the
defaultqueue, to test #1663 before it merges intomain. Pushing to this branch or closing this pull request removes #1663 from the queue.What this draft tests
Mergify checks that #1663 still passes CI on top of
main. CI runs on this draft's code, built in this order:mainat92830db🎉 Where it stands: checks passed
CI passed on this draft.
Follow the
defaultqueue in the dashboardWhat happens next
mainand closes this draft.Metadata for CI tooling, read by
mergify ciRequired conditions of queue rule
defaultfor mergecheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergemain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge ProtectionsRequired conditions to stay in the queue
-conflict-draftbase = maincheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergelabel = review-okmain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge Protections